Removal of certain default namespace rules #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Wertenteil <[email protected]>
|
/describe |
PR Analysis
PR Feedback
How to use
|
codiumai-pr-agent-free
bot
changed the title
|
Summary:
|
YiscahLevySilas1
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type:
Refactoring
PR Description:
This PR involves the removal of certain rules related to the default namespace. The rules removed include 'limitrange-in-default-namespace', 'resourcequota-in-default-namespace', 'networkpolicy-in-default-namespace', 'resources-event-1-in-default-namespace', and 'resources-event-2-in-default-namespace'. The removal includes the corresponding rego files, metadata files, test files, and references in the 'C-0212-thedefaultnamespaceshouldnotbeused.json' file.
PR Main Files Walkthrough:
controls/C-0212-thedefaultnamespaceshouldnotbeused.json: Removed references to the deleted rules.rules/limitrange-in-default-namespace/*: All files related to the 'limitrange-in-default-namespace' rule have been removed.rules/resourcequota-in-default-namespace/*: All files related to the 'resourcequota-in-default-namespace' rule have been removed.rules/networkpolicy-in-default-namespace/*: All files related to the 'networkpolicy-in-default-namespace' rule have been removed.rules/resources-event-1-in-default-namespace/*: All files related to the 'resources-event-1-in-default-namespace' rule have been removed.rules/resources-event-2-in-default-namespace/*: All files related to the 'resources-event-2-in-default-namespace' rule have been removed.